Fix Tux' velocity on frozen enemy #3341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagtoy
approved these changes
Aug 18, 2025
tobbi
reviewed
Aug 19, 2025
|
|
||
| if (hit.bottom && badguy->is_frozen()) | ||
| m_on_ground_flag = true; | ||
| m_physic.set_velocity_y(0); |
There was a problem hiding this comment.
Is the set_velocity_y call supposed to be part of the if statement in line 2416 or not?
If it does, it needs braces after the if. If not, the indentation needs to get fixed or, even better, the call needs to be put in a new line.
Oh thanks. Didn't notice that. |
tobbi
approved these changes
Aug 19, 2025
mrkubax10
added
category:code
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition to #3232 . Tux' velocity increased while being on a jumping frozen enemy. I fixed it by setting the velocity to zero.